这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: Add Bitcoin Cashu support #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

feat: Add Bitcoin Cashu support #24

wants to merge 5 commits into from
+340 −26

Conversation

@yashbhutwala
Copy link

@yashbhutwala yashbhutwala commented Sep 17, 2025 •
edited
Loading

Summary

@yashbhutwala yashbhutwala requested a review from a team as a code owner September 17, 2025 01:48
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yashbhutwala, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the payment capabilities by integrating Bitcoin Cashu support into the existing x402 framework. It enables the use of blinded ecash for agent payments, alongside traditional card rails, by introducing a new cashu-token scheme. The changes involve updating documentation, configuring sample agents with Cashu wallets, and implementing the necessary logic for payment processors to verify and settle Cashu transactions through an x402 facilitator.

Highlights

  • Cashu Integration: Introduces support for Bitcoin Cashu payments within the x402 framework, enabling agents to use blinded ecash alongside existing payment methods.
  • Documentation Updates: Adds detailed explanations of the Cashu-backed cashu-token scheme, including testnet and mainnet mint configurations, and updates the x402 purchase sample walkthrough.
  • Payment Method Management: Enhances payment method handling to recognize and process Cashu wallets, including specific eligibility criteria like mint URL and network.
  • Facilitator Interaction: Implements logic for the Merchant Payment Processor to interact with an x402 facilitator for verifying and settling Cashu payments.
  • Demo Wallet Configuration: Includes a sample Cashu demo wallet with pre-configured proofs for testing purposes within the account_manager.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Bitcoin Cashu payments, which is a great addition. The changes are comprehensive, covering documentation, sample data, and the core logic for handling the new payment scheme through the x402 facilitator. The implementation is solid. I've left a couple of minor suggestions to improve code clarity and maintainability. Overall, great work!

@yashbhutwala yashbhutwala changed the title Add Bitcoin Cashu support feat: Add Bitcoin Cashu support Sep 17, 2025
@yashbhutwala
Copy link
Author

yashbhutwala commented Sep 17, 2025

/gemini review

@yashbhutwala yashbhutwala mentioned this pull request Sep 17, 2025
Open
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Bitcoin Cashu payments via the x402 protocol, which is a significant feature addition. The changes are well-integrated into the existing agent payment flow, covering documentation, sample data, and agent logic for handling the new cashu-token scheme. My review focuses on improving code clarity, robustness, and maintainability. I've identified some minor issues, such as redundant sample data and opportunities to make the code more robust against unexpected falsy values. Overall, this is a solid implementation of the new functionality.

@yashbhutwala yashbhutwala mentioned this pull request Sep 17, 2025
Open
@yashbhutwala yashbhutwala force-pushed the cashu-facilitator branch 2 times, most recently from e3f99da to 2fb7b1b Compare September 17, 2025 13:54
@yashbhutwala
Copy link
Author

yashbhutwala commented Sep 17, 2025

/gemini summary

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Sep 17, 2025

Summary of Changes

This pull request significantly extends the payment capabilities of the system by integrating Bitcoin Cashu support. It allows for the processing of blinded ecash payments, enhancing privacy and flexibility for agent-based transactions. The changes involve updating core payment processing logic, introducing new payment method handling, and providing comprehensive documentation and sample configurations to facilitate adoption and testing of this new payment scheme.

Highlights

  • Bitcoin Cashu Support: Introduced a new cashu-token scheme to enable Bitcoin Cashu payments, allowing agents to spend blinded ecash within the x402 framework.
  • x402 Facilitator Integration: Integrated the x402 facilitator to verify and settle Cashu payments, ensuring secure and accountable transactions.
  • Documentation Updates: Updated documentation to detail the Cashu-backed cashu-token scheme, its alignment with NUT-24, and sample Bitcoin testnet/mainnet mint configurations.
  • Sample Cashu Wallet: Added a sample Cashu wallet to the credentials_provider_agent for demonstration purposes, including pre-generated blinded proofs.
  • Agent Behavior Modification: Modified the merchant agent to advertise Cashu-backed x402 capabilities and the shopping agent to route interactions through the new cashu-token scheme when selected.
Changelog
  • docs/topics/ap2-and-x402.md
    • Added a new section describing the Cashu-backed cashu-token scheme, its technical details (NUT-24 alignment, cashuB transport), and default mint configurations for Bitcoin testnet and mainnet.
  • samples/python/scenarios/a2a/human-present/x402/README.md
    • Updated the link to the A2A x402 extension repository.
    • Revised the 'Key Features' section to reflect the new Cashu-backed x402 capability advertised by the Merchant Agent and the routing of Cashu payments by the Shopping Agent.
  • samples/python/src/roles/credentials_provider_agent/account_manager.py
    • Introduced a 'Cashu demo wallet' entry, complete with sample Cashu tokens, mint URLs, facilitator URL, network details, and a balance, for testing the new payment scheme.
  • samples/python/src/roles/credentials_provider_agent/tools.py
    • Modified _get_eligible_payment_method_aliases to also return the full payment_methods list.
    • Implemented new logic in _payment_method_is_eligible to correctly identify and validate x402:cashu-token payment methods based on type, mint URL, and network criteria.
  • samples/python/src/roles/merchant_agent/sub_agents/catalog_agent.py
    • Added x402:cashu-token as a supported payment method in the CartMandate, specifying bitcoin-testnet and a test mint URL.
  • samples/python/src/roles/merchant_payment_processor_agent/tools.py
    • Added json and httpx imports.
    • Refactored _complete_payment to conditionally call a new _handle_cashu_payment function when the payment method is x402:cashu-token.
    • Implemented _handle_cashu_payment, an asynchronous function responsible for normalizing Cashu tokens, constructing payment payloads, and interacting with the x402 facilitator's /verify and /settle endpoints to process Cashu payments.
  • samples/python/src/roles/shopping_agent/subagents/payment_method_collector/tools.py
    • Stored the eligible_payment_methods in the tool_context.state for later use.
  • samples/python/src/roles/shopping_agent/tools.py
    • Modified create_payment_mandate to dynamically set the method_name to x402:cashu-token if a Cashu payment method is selected, otherwise defaulting to CARD.
    • Stored the selected_payment_method in the tool_context.state.
Activity
  • yashbhutwala requested a Gemini review.
  • yashbhutwala requested a Gemini summary.
  • Gemini Code Assist provided a low priority comment suggesting simplification of merchant_criteria.data checks.
  • Gemini Code Assist provided a low priority comment recommending defining hardcoded default values as constants for better maintainability.
  • Gemini Code Assist provided a medium priority comment regarding potential issues with using or for encoded and encoded_tokens when dealing with falsy values like empty lists.
  • Gemini Code Assist provided a low priority comment suggesting the removal of a redundant proofs key in account_manager.py.
  • Gemini Code Assist provided a low priority comment suggesting simplification of merchant_criteria.data checks by leveraging its default dictionary factory.
  • Gemini Code Assist provided a low priority comment advising to catch more specific exceptions instead of a broad except Exception for improved robustness.
  • Gemini Code Assist provided a low priority comment on the potential for or to incorrectly replace an empty string with a default value for facilitator_url.
  • Gemini Code Assist provided a low priority comment suggesting a more explicit approach for adding optional keys to dictionaries for better readability and maintainability.

@yashbhutwala
Copy link
Author

yashbhutwala commented Sep 17, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Bitcoin Cashu payments, a significant feature enhancement. The changes are comprehensive, touching upon documentation, sample data, and core logic across multiple agent roles to enable the new payment scheme. The implementation correctly advertises Cashu support, filters payment methods, and adds a new flow to the payment processor for handling Cashu transactions via an x402 facilitator. The code is well-structured, but I've offered a couple of suggestions to improve data consistency in the sample wallet and enhance code readability in the payment handling logic. Overall, this is a solid contribution.

@yashbhutwala yashbhutwala force-pushed the cashu-facilitator branch 2 times, most recently from 4980a1b to 1abe311 Compare September 17, 2025 14:54
@zeroasterisk zeroasterisk added samples Issues that are directly related to samples. Integrations Connectors to providers, frameworks, UIs, etc. labels Sep 17, 2025
@kmcduffie
Copy link
Collaborator

kmcduffie commented Sep 18, 2025

Thank you for the time it took to write this contribution, we thoroughly appreciate your interest and excitement with this project. We are evaluating this contribution and will respond by 1-2 weeks.

@mdoeseckle
Copy link
Collaborator

mdoeseckle commented Oct 23, 2025

Thank you for the time it took to write this contribution, we thoroughly appreciate your interest and excitement with this project. Unfortunately your contribution doesn't align with our long term roadmap so we are going to have to decline this PR at this time.

@mdoeseckle mdoeseckle closed this Oct 23, 2025
@yashbhutwala
Copy link
Author

yashbhutwala commented Oct 29, 2025

Unfortunately your contribution doesn't align with our long term roadmap so we are going to have to decline this PR at this time.

What is this long term roadmap? Why is Bitcoin ecash not on this roadmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Integrations Connectors to providers, frameworks, UIs, etc. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yashbhutwala @kmcduffie @mdoeseckle @zeroasterisk