这是indexloc提供的服务,不要输入任何密码
Skip to content

[aetest] Allow specifying path to dev_appserver binary #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2020
Merged

[aetest] Allow specifying path to dev_appserver binary #226

merged 4 commits into from
Oct 13, 2020

Conversation

jubishop
Copy link
Contributor

by setting the environment variable "APPENGINE_DEV_APPSERVER_BINARY" to the path of an executable file, aetest will now use it to launch the devappserver.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 12, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jubishop
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 12, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 12, 2020
Copy link
Contributor

@sbuss sbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep going back-and-forth on if this should be documented in the aetest package.

I'll leave it up to you

@jubishop
Copy link
Contributor Author

Meh it’d be pretty unlikely anybody else wants to build a completely call-compatible replacement for devappserver so I personally wouldn’t bother.

@sbuss sbuss changed the title support method to launch a devapp server binary instead of python file. [aetest] Allow specifying path to dev_appserver binary Oct 13, 2020
@sbuss sbuss merged commit 5d1c1d0 into golang:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants