[WPEX-3724] Resolve XSS security vulnerability #2612
Merged
+129
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHerman
approved these changes
May 29, 2024
Contributor
EvanHerman
left a comment
There was a problem hiding this comment.
Looks good to me. Works well on my end. Nice work! 👍
AnthonyLedesma
approved these changes
May 29, 2024
Member
AnthonyLedesma
left a comment
There was a problem hiding this comment.
Looks great. I tried to break all the features. 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue with improper escaping of HTML output in the Social Profiles block. The solution implemented (other than ensuring output is properly escaped) is to use
wp_kseswith a defined set of html elements and attributes expected which removes all extraneous attributes.