这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: Added GitHub app authentication #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat: Added GitHub app authentication #97

merged 4 commits into from
Apr 23, 2024

Conversation

@galbirk
Copy link
Contributor

@galbirk galbirk commented May 21, 2023

In this PR I added the feature of authenticating to GitHub API with github app and allowing to fetch metrics about it.

Tests:

$ make test                                                                                                                     
?       github.com/infinityworks/github-exporter        [no test files]
?       github.com/infinityworks/github-exporter/config [no test files]
?       github.com/infinityworks/github-exporter/exporter       [no test files]
?       github.com/infinityworks/github-exporter/http   [no test files]
=== RUN   TestHomepage
Created sequence diagram (2641264843_2166136261.html): /Users/galbirkman/projects/github-exporter/test/.sequence/2641264843_2166136261.html
--- PASS: TestHomepage (0.01s)
=== RUN   TestGithubExporter
time="2023-05-21T16:30:35+03:00" level=info msg="Fetching https://api.github.com/repos/myOrg/myRepo?per_page=100 \n"
time="2023-05-21T16:30:35+03:00" level=info msg="Fetching https://api.github.com/repos/myOrg/myRepo/releases \n"
time="2023-05-21T16:30:35+03:00" level=info msg="Fetching https://api.github.com/repos/myOrg/myRepo/pulls \n"
time="2023-05-21T16:30:35+03:00" level=info msg="API data fetched for repository: https://api.github.com/repos/myOrg/myRepo?per_page=100"
time="2023-05-21T16:30:35+03:00" level=info msg="All Metrics successfully collected"
Created sequence diagram (31181356_2166136261.html): /Users/galbirkman/projects/github-exporter/test/.sequence/31181356_2166136261.html
--- PASS: TestGithubExporter (0.07s)
PASS
ok      github.com/infinityworks/github-exporter/test   1.388s

Closes #95

@ben-z
Copy link

ben-z commented Apr 2, 2024

@henrymcconville can we merge this PR? Would love to have this feature.

henrymcconville
henrymcconville requested changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@henrymcconville henrymcconville left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've marked one of my comments IMPORTANT and added a few minor nitpicks that would be good to address but aren't critical. Would you also be able to rebase off the master branch to resolve the conflicts in config.go and go.sum. Thanks!

@galbirk
Copy link
Contributor Author

galbirk commented Apr 3, 2024

Thanks @henrymcconville !
Will take a look and update. Hopefully in the next few days.

@galbirk
Copy link
Contributor Author

galbirk commented Apr 8, 2024 •
edited
Loading

@henrymcconville I removed duplicated code and added some fields to the Config struct.
I was thinking to create GitHubApp struct specifically for GitHubApp configuration to not overload the Config one. WDYT? For now, all added to the Config struct.

@galbirk galbirk requested a review from henrymcconville April 8, 2024 11:44
henrymcconville
henrymcconville reviewed Apr 23, 2024
View reviewed changes
@henrymcconville henrymcconville self-requested a review April 23, 2024 10:46
@henrymcconville
Copy link
Collaborator

henrymcconville commented Apr 23, 2024

@galbirk Think a separate struct would be nicer but happy with it as is for now. Feel free to raise a follow up PR if you're passionate enough about it being separated 😄

@henrymcconville henrymcconville merged commit d667f9a into githubexporter:master Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymcconville henrymcconville henrymcconville approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable github app authentication

4 participants

@galbirk @ben-z @henrymcconville @galbirk-s1