Allow to specify no targets #48
Conversation
|
Thanks for the PR, could you expand on why you'd be keen to monitor rate limits only using the exporter? Not sure i'm fully understanding the use-case here? |
|
My use case is that I have a service that does not directly connect to Github. The service connects to an external service that connects to the GitHub API. That's why I only want to monitor the GitHub rate limit at the moment in order to check how much quota the external service uses. This github-exporter makes it pretty easy to do so with the requested change :-) |
|
Fair enough, i'm happy to approve. Could you update the docs to reference the behaviour when no value is set? I'll then approve and merge :) |
In order to query only rate limits. Querying targets reduces the remaining rate limits. This should be avoided if the rate limit is the only information of interest.
|
I added the Readme change to the commit. All environment variables are optional now. The application starts without an error when no environment variable is specified. There will be only the info log message that only the rate limit will be scraped. |
In order to query only rate limits. Querying targets reduces
the remaining rate limits. This should be avoided if the rate limit
is the only information of interest.