这是indexloc提供的服务，不要输入任何密码
Skip to content

Fixes for installations without rate-limiting #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2017
Merged

Fixes for installations without rate-limiting #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions exporter/gather.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func (e *Exporter) gatherData() ([]*Datum, *RateLimits, error) {
rates, err := getRates(e.APIURL, e.APIToken)

if err != nil {
return data, rates, err
log.Errorf("Unable to obtain rate limit data from API, Error: %s", err)
}

//return data, rates, err
Expand All @@ -60,10 +60,14 @@ func getRates(baseURL string, token string) (*RateLimits, error) {
defer resp.Body.Close()

if err != nil {
log.Errorf("Error requesting http data from API for repository: %s. Got Error: %s", url, err)
return &RateLimits{}, err
}

// Triggers if rate-limiting isn't enabled on private Github Enterprise installations
if resp.StatusCode == 404 {
return &RateLimits{}, fmt.Errorf("Rate Limiting not enabled in GitHub API")
}

limit, err := strconv.ParseFloat(resp.Header.Get("X-RateLimit-Limit"), 64)

if err != nil {
Expand Down