V2 Rewrite.. #15
Merged
V2 Rewrite.. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@flock3 Ready for another review, added in concurrent requests for when people are querying larger lists of repositories as opposed to orgs. |
Contributor
Author
|
Just spotted a bug when using individual repositories. Will get a fix out shortly. |
iamtgray
reviewed
May 4, 2017
|
|
||
| ENV BIND_PORT 9171 | ||
| ENV GOPATH=/go | ||
| ENV LISTEN_PORT=9171 |
Contributor
There was a problem hiding this comment.
Given that go-common uses safe defaults, should we just remove this from the dockerfile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress rewrite...