Bug fix for slide, slide-only modes #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 4, 2015 21:40
`wrapAll` applied malformed double nested div.
Author
|
Example of improved visuals whether or not in standard page mode, "teacher" slide mode, or "slide only" mode combo. |
Author
|
@github/training-teachers, Mind a quick local test of the Kit functionality? The JS still has a fare ways to go for cleanup, so right now I'm more concerned with behavior and page results than ✨ script. Thanks! |
jordanmccullough
pushed a commit
that referenced
this pull request
Jan 5, 2015
Bug fix for slide, slide-only modes with `?teacher=` feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several undocumented but outstanding JS and layout issues are resolved in this PR:
?teacher=[name]results in empty "Teacher" slide appearingwrapAlltag set is malformed