Updates to templates and scripts #881
Conversation
localden
commented
Oct 14, 2025
- Better branch naming
- Removing redundancies
There was a problem hiding this comment.
Pull Request Overview
This PR enhances branch naming capabilities in the speckit templates and scripts by adding intelligent branch name generation with customization options and GitHub compatibility features.
- Adds
--short-nameparameter to creation scripts for custom branch naming - Implements intelligent branch name generation with stop word filtering and meaningful keyword extraction
- Enforces GitHub's 244-byte branch name limit with automatic truncation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/commands/specify.md | Updated workflow to include branch name generation step and script parameter usage |
| scripts/powershell/create-new-feature.ps1 | Added short name parameter, intelligent naming function, and branch length validation |
| scripts/bash/create-new-feature.sh | Added short name parameter, intelligent naming function, and branch length validation |
| pyproject.toml | Version bump to 0.0.20 |
| CHANGELOG.md | Documents new branch naming features and improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if ! echo "$word" | grep -qiE "$stop_words"; then | ||
| if [ ${#word} -ge 3 ]; then | ||
| meaningful_words+=("$word") | ||
| elif echo "$description" | grep -q "\b${word^^}\b"; then |
There was a problem hiding this comment.
The ${word^^} bash parameter expansion for uppercase conversion may not be available in all bash versions. Consider using tr '[:lower:]' '[:upper:]' for better portability.
| elif echo "$description" | grep -q "\b${word^^}\b"; then | |
| elif echo "$description" | grep -q "\b$(echo "$word" | tr '[:lower:]' '[:upper:]')\b"; then |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| while [ $i -lt $# ]; do | ||
| arg="${!i}" |
There was a problem hiding this comment.
The variable i should be incremented at the beginning of the loop to avoid an infinite loop when parsing the last argument. Currently, i is incremented after processing each argument, but the loop condition checks $i -lt $# which could cause issues with argument indexing.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 43 out of 60 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 43 out of 60 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if ! echo "$word" | grep -qiE "$stop_words"; then | ||
| if [ ${#word} -ge 3 ]; then | ||
| meaningful_words+=("$word") | ||
| elif echo "$description" | grep -q "\b${word^^}\b"; then |
There was a problem hiding this comment.
The ${word^^} syntax for uppercasing is not POSIX compliant and may fail on some shells. Consider using $(echo "$word" | tr '[:lower:]' '[:upper:]') for better compatibility.
| elif echo "$description" | grep -q "\b${word^^}\b"; then | |
| elif echo "$description" | grep -q "\b$(echo "$word" | tr '[:lower:]' '[:upper:]')\b"; then |
|
|
||
| <p align="center"> | ||
| <strong>An effort to allow organizations to focus on product scenarios rather than writing undifferentiated code with the help of Spec-Driven Development.</strong> | ||
| <strong>An open source toolkit that allows you to focus on product scenarios and predictable outcomes instead of vibe coding every piece from scratch.</strong> |
There was a problem hiding this comment.
[nitpick] The term 'vibe coding' may be unclear to some readers. Consider using a more descriptive phrase like 'ad-hoc coding' or 'unstructured coding' for better clarity.
| <strong>An open source toolkit that allows you to focus on product scenarios and predictable outcomes instead of vibe coding every piece from scratch.</strong> | |
| <strong>An open source toolkit that allows you to focus on product scenarios and predictable outcomes instead of ad-hoc coding every piece from scratch.</strong> |