-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Spec Kit Updates (0.0.19) #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added step 4 for project setup verification - Detects and creates/verifies ignore files based on project setup - Includes patterns for .gitignore, .dockerignore, .eslintignore, .prettierignore, .npmignore, .terraformignore, .helmignore - Provides technology-specific patterns (Node.js, Python, Java, C#/.NET, Go) - Includes tool-specific patterns (Docker, ESLint, Prettier, Terraform) - Renumbered subsequent steps 5-9
fix: correctly escape backslashes in TOML slash command outputs
…rification Add ignore file(s) verification step to /speckit.implement command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Specify CLI to version 0.0.19, incorporating several community-contributed fixes and enhancements to improve robustness and functionality.
- Fixed constitution path reference in plan template
- Added comprehensive ignore file management to implementation workflow
- Fixed backslash escaping in TOML file generation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/commands/plan.md | Fixed path reference to constitution.md |
| templates/commands/implement.md | Added detailed ignore file detection and creation logic |
| pyproject.toml | Version bump to 0.0.19 |
| CHANGELOG.md | Added release notes for version 0.0.19 |
| .github/workflows/scripts/create-release-packages.sh | Fixed backslash escaping in TOML generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
feat: support codebuddy ai
…into localden/updates
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
.github/workflows/scripts/create-release-packages.sh:1
- [nitpick] There's an unnecessary blank line added after the codebuddy case that disrupts the consistent formatting of the switch statement.
#!/usr/bin/env bash
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…into localden/updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - Check if the following command succeeds to determine if the repository is a git repo (create/verify .gitignore if so): | ||
| ```sh | ||
| git rev-parse --git-dir 2>/dev/null |
Copilot
AI
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git repository detection command should include proper exit code handling. Consider adding && echo 'is git repo' || echo 'not git repo' or similar to make the detection logic more explicit in the documentation.
| git rev-parse --git-dir 2>/dev/null | |
| git rev-parse --git-dir > /dev/null 2>&1 && echo 'is git repo' || echo 'not git repo' |
| **Common Patterns by Technology** (from plan.md tech stack): | ||
| - **Node.js/JavaScript**: `node_modules/`, `dist/`, `build/`, `*.log`, `.env*` | ||
| - **Python**: `__pycache__/`, `*.pyc`, `.venv/`, `venv/`, `dist/`, `*.egg-info/` | ||
| - **Java**: `target/`, `*.class`, `*.jar`, `.gradle/`, `build/` | ||
| - **C#/.NET**: `bin/`, `obj/`, `*.user`, `*.suo`, `packages/` | ||
| - **Go**: `*.exe`, `*.test`, `vendor/`, `*.out` | ||
| - **Universal**: `.DS_Store`, `Thumbs.db`, `*.tmp`, `*.swp`, `.vscode/`, `.idea/` |
Copilot
AI
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The ignore patterns are hardcoded in documentation. Consider referencing a centralized configuration or making it clear these are examples that should be adapted based on actual project needs.
|
@localden I think I found a bug with this PR, I just tried installing spec kit for cursor and it looks like there's an issue since now the CLI tool is looking for |
No description provided.