github-terms-of-service: Reference-style links for privacy statement #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This link style is documented in [1]. This makes the source a bit easier to read, since the inline label is shorter than the referenced URL. I've also updated a one-off link to the privacy statement's compelled disclosure section. The canonical privacy URL currently 302's to the article: $ curl -sI https://github.com/site/privacy HTTP/1.1 302 Found Date: Sun, 06 Aug 2017 04:41:03 GMT ... Location: https://help.github.com/articles/github-privacy-statement/ ... but it seems more consistent to use the canonical link there instead of linking directly to the articles/ URL. [1]: https://daringfireball.net/projects/markdown/syntax#link
|
/articles |
Contributor
|
Thank you all for the comments and feedback! @wking Closing this pull request since we haven't made changes to the links in this update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What's the name of the policy?
GitHub Terms of Service
2. Is this issue related to a specific section within one of our policies (e.g. the Terms of Service)? If so, please include a link to the section or subsection.
No
3. Did you already open a pull request? If so, please include a link to the PR.
This is the pull request ;).
4. Sometimes it's easier to just put your feedback text into an issue. If that's how you'd prefer to contribute, this is the section to do that.
Reference-style links make the source a bit easier to read, since the inline label is shorter than the referenced URL.
And the one-off link to the privacy statement's compelled disclosure section currently goes straight to
/articles/github-privacy-statement/, while the other privacy links in these terms go to the redirectinghttps://github.com/site/privacy:It seems more consistent to use the canonical link there instead of linking directly to the
/articles/URL.5. Why do you think this section or language needs improvement?
This PR isn't changing any of the legal language; it's just minor Markdown polishing.