This repository was archived by the owner on Jun 21, 2023. It is now read-only.
use version variable in download url #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
reviewed
Jan 22, 2020
There was a problem hiding this comment.
Thank you for the suggestion! However, we don't update this line ourselves. It is done for us automatically by bump-homebrew-formula after every release.
Since it's a static string that gets inserted every time, it would overwrite the #{version} bits that you've proposed here. Therefore, we won't be pulling this in, since it would get undone after the next release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the locations where changes are needed during version update, you can make use of the
#{version}variable in the URL.