这是indexloc提供的服务,不要输入任何密码
Skip to content

Drop /en from docs URL in readme #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

cheshire137
Copy link
Member

@cheshire137 cheshire137 commented Jun 5, 2025

If we omit the /en in the GitHub docs URL, then if there's a non-English translation available and the user's browser requests that other language, we'll render our docs in the user's preferred language instead of defaulting them to English.

Context: https://github.com/github/gh-models/pull/57/files#r2129664982

@cheshire137 cheshire137 self-assigned this Jun 5, 2025
@Copilot Copilot AI review requested due to automatic review settings June 5, 2025 18:09
@cheshire137 cheshire137 requested a review from a team as a code owner June 5, 2025 18:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation link in the README to remove the /en segment from the GitHub Docs URL.

  • Updated the .prompt.yml reference link to use the new path without /en
  • Ensured consistency with other docs URLs
Comments suppressed due to low confidence (1)

README.md:83

  • The markdown list marker and indentation were removed when updating the link, which breaks the list formatting. Restore the leading '-' and proper indentation (e.g., '- Learn more about ...') to maintain the bullet list structure.
Learn more about `.prompt.yml` files here: [Storing prompts in GitHub repositories](https://docs.github-models/use-github-models/storing-prompts-in-github-repositories).

@cheshire137 cheshire137 added the failing-test A CI build is not passing. label Jun 5, 2025
@cheshire137 cheshire137 enabled auto-merge June 5, 2025 21:03
@cheshire137 cheshire137 merged commit 91e723b into main Jun 5, 2025
1 of 4 checks passed
@cheshire137 cheshire137 deleted the cheshire137-patch-1 branch June 5, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failing-test A CI build is not passing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants