-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Description
I was going to fix the error in CONTRIBUTING.md I mentioned in Issue #95. The golangci-lint run
command results in the following...
gh-classroom on main via 🐹 v1.23.6 took 18s
❯golangci-lint run
pkg/classroom/classroom.go:144:21: printf: non-constant format string in call to fmt.Sprintf (govet)
return fmt.Sprintf(a.Classroom.Url)
Context
Platform
MacOS
Also replicated it on CachyOS Linux (Arch based distro)
Submitting a pull request
-
[Fork](https://github.com/github/gh-classroom/fork) and clone the repository
-
Configure and install the dependencies: `go mod tidy`
-
Make sure the tests pass on your machine: `go test -v ./...`
-
Make sure linter passes on your machine: `golangci-lint run` <----- This line causes the error
-
Create a new branch: `git checkout -b my-branch-name`
-
Make your change, add tests, and make sure the tests and linter still pass
-
Push to your fork and [submit a pull request](https://github.com/github/gh-classroom/compare)
-
Please be patient while waiting for your pull request to be reviewed and merged.
Metadata
Metadata
Assignees
Labels
No labels