Team Improvements #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues with GitHub team creation and defensive coding around this edge case.
It looks like the issue is due to an uncaught exception being raised when trying to create a new GitHub team with a given
parent
team and that parent team does not exist. Think of it like the bashmkdir -p
command. If the parent team doesn't exist, we should create it so that the child team can also be created.This PR essentially enables team creation to be handled with the same logic as
mkdir -p
in bash.related: #54