这是indexloc提供的服务,不要输入任何密码
Skip to content

Team Improvements #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2024
Merged

Team Improvements #56

merged 6 commits into from
May 28, 2024

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented May 23, 2024

This pull request addresses issues with GitHub team creation and defensive coding around this edge case.

It looks like the issue is due to an uncaught exception being raised when trying to create a new GitHub team with a given parent team and that parent team does not exist. Think of it like the bash mkdir -p command. If the parent team doesn't exist, we should create it so that the child team can also be created.

This PR essentially enables team creation to be handled with the same logic as mkdir -p in bash.

related: #54

note: when I saved in my editor, it forced rubocop to run which is why you see a fair amount of linting changes here 😞

@GrantBirki GrantBirki added the bug Something isn't working label May 23, 2024
@GrantBirki GrantBirki self-assigned this May 23, 2024
@GrantBirki GrantBirki merged commit 4cd1711 into main May 28, 2024
@GrantBirki GrantBirki deleted the team-improvements branch May 28, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants