Improved testing around yaml expirations 🧪 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the test coverage for YAML file expiration functionality by adding comprehensive test cases and fixture files. The changes focus on improving validation of how the system handles various expiration scenarios in YAML configuration files.
- Adds 6 new YAML test fixture files covering different expiration scenarios (individual usernames, groups, nested structures, invalid dates, etc.)
- Expands the test suite with 6 new test contexts covering edge cases and complex expiration logic
- Adds explanatory comments to clarify test expectations and improve test maintainability
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
spec/unit/fixtures/ldap-config/yaml/expiration-mixed-nested.yaml |
Test fixture for mixed expiration scenarios with nested and/or structures |
spec/unit/fixtures/ldap-config/yaml/expiration-invalid-date.yaml |
Test fixture containing invalid date format to test error handling |
spec/unit/fixtures/ldap-config/yaml/expiration-individual-usernames.yaml |
Test fixture for individual username expiration scenarios |
spec/unit/fixtures/ldap-config/yaml/expiration-ignore-test.yaml |
Test fixture for testing expiration ignoring functionality |
spec/unit/fixtures/ldap-config/yaml/expiration-groups.yaml |
Test fixture for group-level expiration testing |
spec/unit/fixtures/ldap-config/yaml/expiration-all-individual-expired.yaml |
Test fixture where all entries are expired |
spec/unit/entitlements/data/groups/calculated/yaml_spec.rb |
Main test file with expanded test coverage for all expiration scenarios |
northrup
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the test suites around yaml file expirations.
This PR only updates tests and no actual logic that is used in production code/deployments.