这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix input parameter typo in uploading-a-sarif-file-to-github.md #39478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

Fix input parameter typo in uploading-a-sarif-file-to-github.md #39478

merged 2 commits into from
Jul 24, 2025

Conversation

SimonMarquis
Copy link
Contributor

Why:

Closes: #39477

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changing input parameter name to reflect the actual name described in:

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@Copilot Copilot AI review requested due to automatic review settings July 23, 2025 20:55
@welcome Welcome
Copy link

welcome bot commented Jul 23, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copilot
Copilot AI reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a documentation error by correcting the input parameter name for the upload-sarif action in the code scanning documentation. The change ensures the documentation accurately reflects the actual parameter name used in the GitHub Action.

Key changes:

  • Corrects sarif-file to sarif_file to match the actual action parameter name

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025 •
edited
Loading

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@Sharra-writes
Copy link
Contributor

@SimonMarquis That does indeed appear to be correct! Thanks for catching it. I'll get this added to the merge queue once checks are passing.

@Sharra-writes Sharra-writes added this pull request to the merge queue Jul 24, 2025
Merged via the queue into github:main with commit d067697 Jul 24, 2025
41 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@SimonMarquis SimonMarquis deleted the patch-1 branch July 24, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Sharra-writes Sharra-writes Sharra-writes approved these changes

Assignees
No one assigned
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in input parameter described in uploading-a-sarif-file-to-github.md
2 participants
@SimonMarquis @Sharra-writes