fix 403s, registry creds probably not needed #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR removes the custom GHCR registry credentials from the Dependabot configuration to attempt updates against public images only.
- Deletes the top-level
registriesblock - Removes the
registriesreference under the Docker update entry
Comments suppressed due to low confidence (1)
.github/dependabot.yml:3
- Verify that the
scheduleandlabelskeys are still present under this Docker update item; they appear to have been omitted and are required for Dependabot to run correctly.
- package-ecosystem: "docker"
|
I ran the update in Dependabot CLI without creds and it produced a PR. I think since #131 we added dynamic logins for docker so these credentials aren't needed anymore. |
pavera
approved these changes
Jun 18, 2025
|
Confirmed it is working again #1501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing 403s in the Dependabot logs and thought we could try without creds again since all the images are public.
Originally the creds were added in #131 and you can see there was confusion there why they were needed. So let's try again without and see if we can simply things.