Make typescript compile to "es2022"
#1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`es6` is legacy because GitHub actions used to use `node12`, which didn't support some of the newer versions. But GitHub Actions is now on `node20`, which supports `es2022`, so it's safe to let Typescript compile using this much newer syntax. We bumped this particular action to node20 here: * #1104 I'm starting to see Dependabot PR's trying to bump dependencies that are erroring because they can't use newer javascript features, so bumping this unblocks them.
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
honeyankit
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es6is legacy because GitHub actions used to usenode12, which didn't support some of the newer versions.But GitHub Actions is now on
node20, which supportses2022, so it's safe to let Typescript compile using this much newer syntax.We bumped this particular action to node20 here:
I'm starting to see Dependabot PR's trying to bump dependencies that are erroring because they can't use newer javascript features, so bumping this unblocks them.