Switch from GHPR to GHCR for images #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b31a4b1 to
a5d1957
Compare
a5d1957 to
ab30b98
Compare
mattt
approved these changes
Mar 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our updater action currently retrieves the proxy images via the following namespaces:
These resources are hosted on the GitHub Package Registry's docker service which has been superseded by the GitHub Container Registry.
On the package pages for these two containers, we prefer to use their new namespaces:
There isn't a deprecation date for
docker.pkg.github.combut we the fact we use the old service is more of a quirk of history than a design choice, so let's update it.Changes
The primarily change is to the configuration and checks on the Docker package registries used, but a significant difference is that on
ghcr.io, the public images do not require an authentication token at all.Our existing code passed in the
GITHUB_TOKENfrom the action runner, which is accepted by bothdocker.pkg.github.comandghcr.iowhen the action runs in cloud, however for GHES runners theGITHUB_TOKENthey receive is actually rejected bygithub.comas it originates from the instance.Simply removing any auth from the call permits this to work as an anonymous pull regardless of the runner environment.