这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@riley-kohler
Copy link
Contributor

@riley-kohler riley-kohler commented Jul 22, 2025

Pull Request

Proposed Changes

This change adds support for a base64 encoded private key which helps to avoid issues with retrieving, setting, and passing around an environment variable value that contains newlines which may be required for some enterprise secret management strategies. The base64 parsing was made conditional to avoid breaking existing setups while allowing the option for those that might need it.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahpook ahpook closed this Jul 24, 2025
@ahpook ahpook reopened this Jul 24, 2025
@Miablo Miablo added the enhancement New feature or request label Jul 24, 2025
@riley-kohler
Copy link
Contributor Author

Encountering some issues locally with next build failing if the PRIVATE_KEY env is not set. I would think that the envs shouldn't be necessary until executing the built next bundle but I'll at least make it so that the logic I added doesn't fail if the env isn't set.

@riley-kohler riley-kohler force-pushed the add-base64-encoded-private-key-support branch from 10deedd to 893e2ec Compare July 25, 2025 04:22
@riley-kohler riley-kohler enabled auto-merge (squash) July 25, 2025 04:24
@riley-kohler riley-kohler merged commit e9e03c9 into github-community-projects:main Jul 29, 2025
6 of 12 checks passed
@riley-kohler riley-kohler deleted the add-base64-encoded-private-key-support branch July 29, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants