Resolve #2111 and #2120: Allow _DummyThread.is_alive to return False after fork #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a slight lie (this should only ever be the case after forking)
embray
commented
Jul 2, 2025
src/gevent/threading.py
Outdated
| # Instead, allow _DummyThreads to actually return False for is_alive() if it's been | ||
| # cleaned up after a fork. | ||
| def isAlive(self): | ||
| return not self._is_stopped |
There was a problem hiding this comment.
Hmm, turns out since Python 3.13 _DummyThread.is_alive() is actually:
def is_alive(self):
if not self._handle.is_done() and self._started.is_set():
return True
raise RuntimeError("thread is not alive")
So that's a bit of a digression from my earlier plan for this... Maybe it would be better to simply not assert not thread.is_alive() for dummy threads because the intended semantics seem to be this is either always True or undefined behavior...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me this resolves #2111 on Python 3.11.x
While we're at it also resolve #2120
Supersedes #2117