-
Notifications
You must be signed in to change notification settings - Fork 13
Use blas[accelerate] to take advantage of Apple Silicon GPU. #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Resolves #317. |
Any way to test that the change is actually working? |
From #317
Then maybe the change should be conditional on the platform (i.e. Accelerate only enabled on Apple silicon)? |
I can do some timing on a simulation I'm working on, however it is with 2312, which will have to built separately. |
That speedup was too substantial, so I re-ran the simulation 3 times with OpenBLAS and 3 times with Accelerate BLAS:
Time reduction: 5.85% |
Also sets blas[blis], which should offer some improvement on Intel platforms.
8b4f8d0
to
cd5aa2d
Compare
I have updated the PR to use platform-specific BLAS implementations. Accelerate is used on the Apple Silicon platforms and BLIS was selected for Intel as |
Thanks for the work! I'm fine with doing the change then.
Any reason why not to leave it to the whatever is the default in conda on that platform? |
The rationale is that in the SO comment referenced above there was a performance improvement of 20.9% when selecting BLIS over OpenBLAS. |
Great. Then it makes sense to me that we make that change too. |
@oursland Thanks for the work! |
No description provided.