-
-
Notifications
You must be signed in to change notification settings - Fork 372
ci: dependency review action #4191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @mdtro , this sounds like a good idea. Regarding the pinned versions, will a github bot automatically submit PRs for us to upgrade this tool? Or will we have to monitor that tool to see if there are updates? I don't want to set it and forget it and let it slowly rot. |
Dependabot's current configuration on this repo won't update these since we have the SHAs pinned. We would need to enable version updates (instead of just security updates). I can do that in this PR if you'd like. :) |
@armcknight Scratch that, it looks like Dependabot is already configured here to do version updates on GitHub Actions. So yes, it should be auto-updated. 🎉 sentry-cocoa/.github/dependabot.yml Lines 13 to 16 in 2a769ba
|
armcknight
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mdtro ❤️ !
| name: 'Dependency Review' | ||
| on: | ||
| pull_request: | ||
| branches: ['master'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdtro should this be main?
|
@mdtro should we also make sure this is part of the required status checks for merging to main? |
Add dependency review action. Any new dependencies added with known high or critical vulnerabilities will fail CI.