fix: handle invalid NSUnderlyingErrorKey #4144
Conversation
|
Hi @jmkrein, |
krystofwoldrich
left a comment
There was a problem hiding this comment.
The fix looks good to me! But before we can merge it, one of the code owner will need to review it as well.
|
No worries on the delay, I totally understand. Thank you for the review, @krystofwoldrich! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4144 +/- ##
=============================================
+ Coverage 91.377% 91.410% +0.033%
=============================================
Files 605 605
Lines 48267 48302 +35
Branches 17409 17440 +31
=============================================
+ Hits 44105 44153 +48
+ Misses 4070 4057 -13
Partials 92 92
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
We just need an entry for the CHANGELOG |
14fbe63 to
4b13194
Compare
📜 Description
Fix an app crash that occurs when trying to log an invalid value for the key
NSUnderlyingErrorKeywithin theuserInfoof anNSError.💡 Motivation and Context
Fixes #4143
Huge credit to dohyeondk for helping identify the root cause of this issue.
💚 How did you test it?
Added two new unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps