这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: TARGET_OS_VISION not defined for macOS #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: TARGET_OS_VISION not defined for macOS #3585

merged 2 commits into from
Jan 30, 2024

Conversation

@brustolin
Copy link
Contributor

@brustolin brustolin commented Jan 29, 2024

Added

#ifndef TARGET_OS_VISION
#define TARGET_OS_VISION 0
#endif

to fix compilation on CI for macOS

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1291.48 ms 1321.53 ms 30.05 ms
Size 21.58 KiB 418.14 KiB 396.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
26d116c 1196.14 ms 1209.51 ms 13.37 ms
e324230 1252.69 ms 1274.56 ms 21.87 ms
56ec5d0 1236.65 ms 1261.90 ms 25.25 ms
7cd187e 1243.56 ms 1250.20 ms 6.64 ms
53a8885 1241.02 ms 1270.66 ms 29.64 ms
f74904f 1229.02 ms 1244.91 ms 15.89 ms
881a955 1209.47 ms 1225.94 ms 16.47 ms
98cca71 1199.08 ms 1227.36 ms 28.28 ms
b9a9ffd 1201.61 ms 1215.06 ms 13.45 ms
3e7aa41 1214.02 ms 1238.84 ms 24.82 ms

App size

Revision Plain With Sentry Diff
26d116c 21.58 KiB 417.87 KiB 396.29 KiB
e324230 22.85 KiB 408.87 KiB 386.02 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.69 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
53a8885 20.76 KiB 434.65 KiB 413.89 KiB
f74904f 21.58 KiB 418.71 KiB 397.12 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
b9a9ffd 21.58 KiB 418.43 KiB 396.85 KiB
3e7aa41 20.76 KiB 432.31 KiB 411.55 KiB

@brustolin brustolin marked this pull request as ready for review January 30, 2024 07:19
philipphofmann
philipphofmann approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 52e4912 into main Jan 30, 2024
@brustolin brustolin deleted the fix/vision-family branch January 30, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@armcknight armcknight Awaiting requested review from armcknight

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brustolin @philipphofmann @getsentry-bot