test: Add Scope maxBreadcrumb edge case tests #3581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two test cases for edge cases when adding breadcrumbs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
=============================================
+ Coverage 89.262% 89.283% +0.020%
=============================================
Files 529 529
Lines 57716 57751 +35
Branches 20653 20665 +12
=============================================
+ Hits 51519 51562 +43
+ Misses 5287 5278 -9
- Partials 910 911 +1
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two test cases for edge cases when adding breadcrumbs.
I wrote these tests while investigating #3341.
#skip-changelog