fix: adverse frame timestamps #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
commented
Sep 26, 2022
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4a0c282 | 1228.60 ms | 1250.74 ms | 22.14 ms |
| 0fdf0b2 | 1266.27 ms | 1277.90 ms | 11.63 ms |
| e958899 | 1233.02 ms | 1261.86 ms | 28.84 ms |
| 172c95a | 1220.08 ms | 1251.74 ms | 31.66 ms |
| 4c1fab4 | 1222.96 ms | 1251.00 ms | 28.04 ms |
| 0fdf0b2 | 1194.37 ms | 1227.90 ms | 33.53 ms |
| 864c39a | 1239.45 ms | 1256.76 ms | 17.31 ms |
| c929040 | 1254.84 ms | 1278.42 ms | 23.58 ms |
| 9fc2dd0 | 1246.14 ms | 1275.00 ms | 28.86 ms |
| a5ca27b | 1231.31 ms | 1252.56 ms | 21.25 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4a0c282 | 20.51 KiB | 333.10 KiB | 312.60 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| e958899 | 20.51 KiB | 331.92 KiB | 311.41 KiB |
| 172c95a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 4c1fab4 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| c929040 | 20.51 KiB | 333.10 KiB | 312.59 KiB |
| 9fc2dd0 | 20.50 KiB | 331.79 KiB | 311.28 KiB |
| a5ca27b | 20.51 KiB | 331.81 KiB | 311.31 KiB |
Previous results on branch: armcknight/fix-adverse-frame-timestamps
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c531074 | 1236.12 ms | 1268.82 ms | 32.70 ms |
| e2ea18c | 1242.02 ms | 1246.00 ms | 3.98 ms |
| 37076bb | 1239.20 ms | 1266.59 ms | 27.39 ms |
| 34356a8 | 1241.88 ms | 1263.96 ms | 22.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c531074 | 20.51 KiB | 333.15 KiB | 312.65 KiB |
| e2ea18c | 20.51 KiB | 333.15 KiB | 312.65 KiB |
| 37076bb | 20.51 KiB | 331.74 KiB | 311.23 KiB |
| 34356a8 | 20.51 KiB | 333.16 KiB | 312.65 KiB |
Member
philipphofmann
left a comment
There was a problem hiding this comment.
A test is missing and a changelog entry.
rename to 'nextFrameTimestamp' instead
issue here is that there is no tracer to have profiling enabled, which we check for before committing the timestamps to bookkeeping; need to mock either the tracer or the frames tracker to override the check for the tests
and also for frame rate tiemstamps
…s made before recording a frame rate, and dont record insignifant rate chantes; always record everythin when testing instead of checking if profiling is enabled
55e0adc to
056c37b
Compare
f9c84d4 to
e2de31e
Compare
Member
Author
|
@philipphofmann check out the new tests here. |
Member
Author
|
The vlc integration test failure looks to be unrelated to these changes. |
Member
Fixed here #2251 by @kevinrenskers. |
kevinrenskers
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that our profiling timestamps for slow/frozen frames all had the same value for start/end. The same code that should've executed after recording the timestamp was also before it, looks like a rebase gone wrong or something.
I also renamed a variable because the synonyms "last" and "previous" did not help to distinguish them.