这是indexloc提供的服务，不要输入任何密码
Skip to content

test: Fix stuck tests on master branch #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2022
Merged

test: Fix stuck tests on master branch #2285

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8bc2cef
test: Fix stuck tests on master branch
philipphofmann Oct 13, 2022
45bf268
Undo test config
philipphofmann Oct 13, 2022
b785808
Fix 1
philipphofmann Oct 13, 2022
06dc897
test
philipphofmann Oct 13, 2022
a63776a
Disable adding context
philipphofmann Oct 13, 2022
5e0a540
Undo changes
philipphofmann Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Tests/SentryTests/TestUtils/SentryTestObserver.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,16 @@ - (instancetype)init

// The SentryCrashIntegration enriches the scope. We need to install the integration
// once to get the scope data.
[SentrySDK startWithOptionsObject:options];

self.scope = [[SentryScope alloc] init];
[SentryCrashIntegration enrichScope:self.scope
crashWrapper:[SentryCrashWrapper sharedInstance]];
// When running the SentryTestObserver the code gets stuck when accessing the
// UIScreen.mainScreen in SentryCrashIntegration. We disable adding extra context for now.
// Ideally we somehow check here if we can access UIScreen.mainScreen, see
// https://github.com/getsentry/sentry-cocoa/issues/2284
// [SentrySDK startWithOptionsObject:options];
//
// self.scope = [[SentryScope alloc] init];
// [SentryCrashIntegration enrichScope:self.scope
// crashWrapper:[SentryCrashWrapper sharedInstance]];

self.options = options;
}
Expand Down