Detect prewarmed starts with env variable #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop reporting pre warmed app starts based on the ActivePrewarm env variable. Increase the SENTRY_APP_START_MAX_DURATION to 180.
4 tasks
brustolin
reviewed
Jul 1, 2022
brustolin
approved these changes
Jul 1, 2022
Contributor
brustolin
left a comment
There was a problem hiding this comment.
LGTM.
I think it would be nice if we report anything to sentry when a pre-warm happens, so we can analyse the data later.
Co-authored-by: Dhiogo Brustolin <dhiogorb@gmail.com>
Member
Author
Yep, that's the next item on my to-do list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Stop reporting pre-warmed app starts based on the ActivePrewarm
env variable. Increase the SENTRY_APP_START_MAX_DURATION
to 180.
Related to #1899 and #1896.
💡 Motivation and Context
This is a preparation for fixing GH-1897. First, we want to stop reporting wrong app start data. After that, we can open a PR to start reporting pre-warmed app starts.
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps
GH-1897, which means reporting pre-warmed app starts.