Appearance UI keep value #2979
Open
Appearance UI keep value #2979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nging function or workspace
…et when changing function or workspace
…set when changing function or workspace
…eset when changing function or workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using The Aspect / Appearance module, the values we put, notably size ranking, are not kept and reset when doing new workspace.
This patch keep value set for the Size and Color Aspect Module (PartitionColor will be done independently due to complexity)
This patch also fix a potential "leak" where the listener weren't cleaned properly and stacking up when
*TransformerPanel.setup()would be invoked.Current Behaviour:
01_Rephi_Appearance_value_not_kept_.mp4
New Behaviour :
02_Gephi_Appearance_keep_value_.mp4
Checklist
Added tests?
Added to documentation?