fix: compatibility with og:locale #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
Contributor
Author
|
I created a workaround in the upstream (hexojs/hexo#3921) to minimize breaking change. Despite that, I still think this PR is necessary. |
Owner
|
You are thoughtful, thanks for your great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change introduced in hexojs/hexo#3808,
og:localeOpen Graph tag only accepts "language_TERRITORY" format.Since "language_TERRITORY" breaks multilingual support, user should instead use "language-TERRITORY" format which is automatically transformed to "language_TERRITORY" in
open_graph()helper.However, "language-TERRITORY" still breaks multilingual support for non-ZH users, this PR fixes that.
See official list (by Facebook; Hexo only checks the length, not the value itself) of supported locales.