-
Notifications
You must be signed in to change notification settings - Fork 56
Update libraries and load them from cdn #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More coverage in China https://www.jsdelivr.com/network
|
awesome contribution, LGTM except the scroll arrows of fancybox gallery. may need following code? <a data-fancybox="gallery" href="big_1.jpg"><img src="small_1.jpg"></a> |
Add gallery attribute value for fancybox 3 syntax
serve libraries with the latest minor update
|
yeah, the btw, don't mind the Utterances comment not showing. I'm trying (and failing) to move the library to CDN. This PR still use the original Utterances link. |
|
I see, great thanks 👍 |
|
please merge if there is no issue. The migration and testing of Utterances will take a while and probably doesn't work. I'll create another PR if it works. |
|
Just in case someone suggest upgrading to fontawesome 5, I don't include it in this PR because it can be confusing to new users (of this theme). <li><a href="<%= theme.links[key] %>"><span class="fa fa-<%= key %>"></span></a></li>only display solid icons, whereas that same line in v4 (currently used in this theme) can display all icons. To display brand icons, you need <li><a href="<%= theme.links[key] %>"><span class="fa fab-<%= key %>"></span></a></li>But having the above line means A possible workaround is to separate the theme.links to solid and brand icons, <li><a href="<%= theme.links.solid[key] %>"><span class="fa fa-<%= key %>"></span></a></li>
<li><a href="<%= theme.links.brands[key] %>"><span class="fa fab-<%= key %>"></span></a></li>Otherwise, use only one style. So, keep this in mind if you want to use v5. |
|
@weyusi thanks reminder. Use one style may be better, I think. |
Upgrade to (as of this PR)
Load following libraries from jsDelivr CDN (which claim to have good coverage in China):
Some syntax have been modified for compatibility with newer versions,
new Clipboard()tonew ClipboardJS()for clipboard.js 2.0+fancyboxclass todata-fancyboxattribute andtitletodata-captionattribute for fancybox 3.0+SRI attribute is considered, but not implemented because version range is used (instead of a specific version).
I created a github page with these commit https://weyusi.github.io/hexo-testing/
Edit: Reason of not updating fontawesome to v5.