MusicXML: Fix slurs over bars and voices #81
Conversation
|
Thank you! @PeterBjuhr can you comment? |
|
SlurCount can't be an integer due to python's pass by value (copy). This means it's not possible to just pass along an integer expecting the function to modify it by reference, the alternative would be to modify and return the modified value. By using an object instance, only the pointer is copied, but I can still modify the instance. I could remove the inc and dec methods, and just make its users modify count directly. |
|
Ah, that's clear! No it's perfectly to keep it, then. As @PeterBjuhr is the MusicXML man, I'll wait his response ;) |
c669a81 to
0944201
Compare
|
Rebased against latest release |
0944201 to
123e9e5
Compare
|
I've added phrasing indication to the slur object. |
9d5d7bb to
681854b
Compare
Handles the merging of slurs from multiple voices and slurs over bars much better.
681854b to
6e04012
Compare
|
Any update on this? |
…-and-voices # Conflicts: # ly/musicxml/ly2xml_mediator.py
|
I've merged master into this branch to fix a merge conflict. Looking at the test files and briefly on the code I don't see anything that speaks against merging this, @PeterBjuhr |
These changes should make it possible keep slurs over multiple bars and merge other voices with slurs in a ScoreSection.
Tests are added, but the test script must be modified (not pushed here) in order to run on my machine (Ubuntu 16.10, python 3.5).