-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Filter by close icon added for mobile screen #12008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@parlough I need help. When i don't use div for resource-filter-group-wrapper and use css given below then close functionality not works but filter_list icon in mobile screen show content every time when open/close slider .close-icon { Screen.Recording.2025-05-13.at.4.09.17.PM.mov |
Please review, @parlough. |
Thanks for working on this improvement @zalabhavy! Sorry that I haven't had a chance to review your PR yet, I've been away for the past week. I'll try to make time to review this tomorrow. I haven't had a chance to review your CSS or investigate yet, but from a quick look at the video, I'd consider implementing the behavior of the button by adding a click handler to the button with JS, similar to the existing handling for pressing the website/src/content/assets/js/learning-resources-index.js Lines 283 to 287 in a7876e7
|
Greetings from stale PR triage! Is this change still active? |
@Piinks Hello ! |
A close icon/button should be added to the "Filter by" wrapper on mobile screens to allow users to easily close the sidebar.
Fixed #11980
he close button works properly, but despite trying multiple times, I couldn't fix the issue where, after closing the filter once, clicking the filter icon again on a mobile screen doesn't show the filter content inside the card.
Screen.Recording.2025-05-13.at.3.56.50.PM.mov
Presubmit checklist