这是indexloc提供的服务,不要输入任何密码
Skip to content

Disabled Patrol (and devtools) tests due to failure #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

justinmc
Copy link
Contributor

The Patrol tests are failing due to a dependency error. I'm trying to bump the customer tests but can't because of this. See #461, which shows the failing tests.

We definitely should re-enable these test once they're fixed! I'm just trying to get things moving along.

From this run I see:

>> flutter packages get
| Resolving dependencies...
| Because leancode_lint >=14.3.0 <14.4.0 depends on analyzer ^6.7.0 and analyzer >=6.6.0 <6.9.0 depends on macros >=0.1.2-main.3 <0.1.3, leancode_lint >=14.3.0 <14.4.0 requires macros >=0.1.2-main.3 <0.1.3 or analyzer ^6.9.0.
| Because macros >=0.1.2-main.4 <0.1.3-main.0 depends on _macros 0.3.2 from sdk and macros >=0.1.2-main.2 <0.1.2-main.4 depends on _macros 0.3.1 from sdk, macros >=0.1.2-main.2 <0.1.3-main.0 requires _macros 0.3.1 or 0.3.2 from sdk.
| Thus, leancode_lint >=14.3.0 <14.4.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because leancode_lint >=14.4.0 <15.1.0 depends on analyzer ^6.11.0, leancode_lint >=14.3.0 <15.1.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk.
| And because analyzer >=6.9.0 <7.3.0 depends on macros >=0.1.3-main.0 <0.1.4 which depends on _macros 0.3.3 from sdk, leancode_lint >=14.3.0 <15.1.0 requires _macros 0.3.1 or 0.3.2 or 0.3.3 from sdk.
| So, because _macros from sdk doesn't exist (could not find package _macros in the Dart SDK) and patrol_cli depends on leancode_lint ^14.3.0, version solving failed.
|
|
| You can try the following suggestion to make the pubspec resolve:
| * Try upgrading your constraint on leancode_lint: flutter pub add dev:leancode_lint:^17.0.0
| Failed to update packages.
ERROR: Could not run "flutter pub get" in packages/patrol_cli, which was specified as an update directory.
Deleting temporary directory...
Contacts: piotr.denert@leancode.pl, piotr.maszota@leancode.pl, mateusz.wojtczak@leancode.pl, julia.borkowska@leancode.pl

They are failing due to a dependency problem.
@justinmc justinmc self-assigned this Jul 11, 2025
@justinmc
Copy link
Contributor Author

FYI @piotruela. I'll also send an email to the email addresses listed as contact info for Patrol.

@pdenert
Copy link

pdenert commented Jul 11, 2025

@justinmc thanks for letting us know. We'll try to address this asap

@harryterkelsen
Copy link
Contributor

FYI I'm hitting the same problem in my PR #463

@harryterkelsen harryterkelsen self-requested a review July 11, 2025 20:12
harryterkelsen
harryterkelsen previously approved these changes Jul 11, 2025
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc
Copy link
Contributor Author

@harryterkelsen Can you resubmit your review? I hard to push a merge commit due to conflicts and it invalidated your review.

harryterkelsen
harryterkelsen previously approved these changes Jul 11, 2025
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc
Copy link
Contributor Author

Devtools tests appear to be failing now after my merge commit @kenzieschmoll .

@justinmc
Copy link
Contributor Author

@harryterkelsen One more re-review needed from you :)

@justinmc justinmc changed the title Disabled Patrol tests due to failure Disabled Patrol (and devtools) tests due to failure Jul 11, 2025
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit 7afa986 into flutter:main Jul 14, 2025
12 checks passed
@justinmc justinmc deleted the disable-patrol branch July 14, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants