-
Notifications
You must be signed in to change notification settings - Fork 119
Disabled Patrol (and devtools) tests due to failure #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
They are failing due to a dependency problem.
FYI @piotruela. I'll also send an email to the email addresses listed as contact info for Patrol. |
@justinmc thanks for letting us know. We'll try to address this asap |
FYI I'm hitting the same problem in my PR #463 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@harryterkelsen Can you resubmit your review? I hard to push a merge commit due to conflicts and it invalidated your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Devtools tests appear to be failing now after my merge commit @kenzieschmoll . |
@harryterkelsen One more re-review needed from you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Patrol tests are failing due to a dependency error. I'm trying to bump the customer tests but can't because of this. See #461, which shows the failing tests.
We definitely should re-enable these test once they're fixed! I'm just trying to get things moving along.
From this run I see: