This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Explanation for casting details to implementations #4008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickdijk
suggested changes
Jun 3, 2021
mvanbeusekom
suggested changes
Jun 3, 2021
There was a problem hiding this comment.
The description looks good, nice and detailed. I added some suggestions that you can have a look at.
One thing in particular, I learned from Stuart that we should try to refrain from using "you" as it might lead to confusion (who is the "you" that is being referred to). If have marked a few places where "you" is used but not all of them. It would be good to go over the whole paragraph and make the necessary updates.
and other textual improvements
# Conflicts: # packages/in_app_purchase/in_app_purchase/CHANGELOG.md
mvanbeusekom
reviewed
Jun 4, 2021
There was a problem hiding this comment.
@renefloor I have added two more change suggestions, have a look if you agree
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
danielroek
reviewed
Jun 4, 2021
Co-authored-by: Daniël <32639467+danielroek@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform specific properties of ProductDetails and PurchaseDetails are removed in the platform interface, but can easily be retrieved by casting the object to the platform specific implementations. This PR adds a section to the readme explaining the casts of both types.
Fixes flutter/flutter#83140
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.