This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_storage] Return error when failing to read file #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests are being added in #1513, once those are landed we can add a test for this. |
|
Added an assertion on the Dart side since the current API doesn't provide a way to catch this exception. I think that this situation could be improved in the future, but also I don't see a downside to adding extra error handling for the missing file case. @kroikie do you think we should go ahead and merge this one? |
|
Additional error handling seems like an improvement on the current implementation so I'll go ahead and merge it. |
|
Thanks for moving forward with this @collinjackson, been away for the past days ❤️ |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
[firebase_storage] Return error when failing to read file and assert that file exists when calling putFile
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Move cloud_firestore to cloud_firestore/cloud_firestore. This is required for federated implementations. * Update docs, version bump to 0.12.10+4 * Fix analysis_options.yaml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when trying to upload a
Filethat doesn't exist, the entire app crashes deep inside the firebase sdk: https://github.com/firebase/firebase-ios-sdk/pull/2458/files#r276273826Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Not sure how to add tests since the tests since to mock out the Objective-C part of the plugins, any help would be appreciated!