这是indexloc提供的服务,不要输入任何密码
Skip to content

[go_router_builder] Change mixin name #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

StevenSorial
Copy link
Contributor

@StevenSorial StevenSorial commented Jul 14, 2025

Fixes #170650

This PR fixes workflows that relied on putting child routes in files different than parent files, which resulted in the (private) mixin being generated in a different file than the route itself.

To avoid releasing a new major version in such a short period, this PR makes the mixin public only if needed. Admittedly makes the behavior somewhat unexpected for the user. @chunhtai @hannah-hyj I will leave that decision for you, whether that's ok or I should make it always public and release a major version instead.

Since this change just fixes a use-case that already didn't compile in 3.x.x, this PR doesn't bump the major version.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@ManuelRauber
Copy link

Works for me for the moment. :)

@StevenSorial StevenSorial marked this pull request as ready for review July 19, 2025 20:25
@StevenSorial StevenSorial requested a review from chunhtai as a code owner July 19, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router] [go_router_builder] New "mixin" feature in go_router_builder 3.0.0 breaks separated routes logic
2 participants