[camera_avfoundation] Implementation swift migration - part 10 #9664
+115
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request migrates captureToFile and getTemporaryFilePath to Swift and updates the dispatch queue handling to use modern Swift APIs. I've provided suggestions to improve the robustness of the new Swift code by avoiding potential runtime issues related to force-indexing and force-casting.
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Show resolved
Hide resolved
Comment on lines
+386
to
+387
| let documentDirectory = FileManager.default.urls(for: .documentDirectory, in: .userDomainMask)[ | ||
| 0] |
There was a problem hiding this comment.
Force-indexing an array with [0] can lead to a runtime crash if the array is empty. While it's unlikely for FileManager.default.urls(for: .documentDirectory, ...) to return an empty array, adopting a safer pattern using .first and handling the optional result will make the code more robust and idiomatic.
private func getTemporaryFilePath(withExtension ext: String, subfolder: String, prefix: String)
throws
-> String
{
guard
let documentDirectory = FileManager.default.urls(
for: .documentDirectory, in: .userDomainMask).first
else {
throw NSError(
domain: NSCocoaErrorDomain, code: NSFileNoSuchFileError,
userInfo: [NSLocalizedDescriptionKey: "Documents directory not found."])
}
let fileDirectory = documentDirectory.appendingPathComponent("camera").appendingPathComponent(
subfolder)
let fileName = prefix + UUID().uuidString
let file = fileDirectory.appendingPathComponent(fileName).appendingPathExtension(ext).path
let fileManager = FileManager.default
if !fileManager.fileExists(atPath: fileDirectory.path) {
try fileManager.createDirectory(
at: fileDirectory,
withIntermediateDirectories: true,
attributes: nil)
}
return file
}e47c2b5 to
f472203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates the 7th chunk of
FLTCamclass to Swift:captureToFilegetTemporaryFilePathWe can also finally switch to Swift interface for dispatch queue specific because all usages are now in Swift.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3