这是indexloc提供的服务，不要输入任何密码
Skip to content

[in_app_purchase] show InAppPurchasePlatform, InAppPurchasePlatformAddition #9642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[in_app_purchase] show InAppPurchasePlatform, InAppPurchasePlatformAddition #9642

wants to merge 2 commits into from

Conversation

arrrrny
Copy link

@arrrrny arrrrny commented Jul 17, 2025 •
edited
Loading

When using storekit as described on the example, it would be useful to show the InAppPurchasePlatform, InAppPurchasePlatformAddition from the package itself. Currently it is not displayed and flutter gives a warning

Screenshot 2025-07-17 at 6 22 56 PM 
The imported package 'in_app_purchase_platform_interface' isn't a dependency of the importing package.
Try adding a dependency for 'in_app_purchase_platform_interface' in the 'pubspec.yaml' file. (dart depend_on_referenced_packages)
import 'package:in_app_purchase_platform_interface/in_app_purchase_platform_interface.dart'
  final InAppPurchaseStoreKitPlatform _iapStoreKitPlatform =
      InAppPurchasePlatform.instance as InAppPurchaseStoreKitPlatform;
  final InAppPurchaseStoreKitPlatformAddition _iapStoreKitPlatformAddition =
      InAppPurchasePlatformAddition.instance!
          as InAppPurchaseStoreKitPlatformAddition;
  late StreamSubscription<List<PurchaseDetails>> _subscription;

It is really not neccessary to add package to pubspec since it is alread coming with this package.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of
Gemini Code Assist for GitHub.
Comments from the gemini-code-assist bot should not be taken as authoritative
feedback from the Flutter team. If you find its comments useful you can
update your code accordingly, but if you are unsure or disagree with the
feedback, please feel free to wait for a Flutter team member's review for
guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@Copilot Copilot AI review requested due to automatic review settings July 17, 2025 15:25
@arrrrny arrrrny requested a review from bparrishMines as a code owner July 17, 2025 15:25
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@google-cla Google CLA
Copy link

google-cla bot commented Jul 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copilot

This comment was marked as outdated.

Sign in to view

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 17, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly exports InAppPurchasePlatform and InAppPurchasePlatformAddition from the in_app_purchase package. This is a useful change that will resolve dependency warnings for developers using platform-specific APIs. My review includes one comment regarding a style convention to ensure the code adheres to the project's standards.

@arrrrny arrrrny requested a review from Copilot July 17, 2025 15:33
Copilot
Copilot AI reviewed Jul 17, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes InAppPurchasePlatform and InAppPurchasePlatformAddition in the main in_app_purchase package, allowing downstream consumers to import these types without adding a direct dependency on the platform interface.

  • Adds exports for InAppPurchasePlatform and InAppPurchasePlatformAddition in in_app_purchase.dart
Comments suppressed due to low confidence (2)

packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart:14

  • Update the package's README or dartdoc comments to mention the newly exported classes InAppPurchasePlatform and InAppPurchasePlatformAddition so users know they are available directly from this package.
        InAppPurchasePlatform,

packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart:14

  • Add a unit test that imports InAppPurchasePlatform and InAppPurchasePlatformAddition from the in_app_purchase package to verify the exports are wired correctly.
        InAppPurchasePlatform,

@stuartmorgan-g
Copy link
Contributor

Thanks for the submission!

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

When using storekit as described on the example, it would be useful to show the InAppPurchasePlatform, InAppPurchasePlatformAddition from the package itself. Currently it is not displayed and flutter gives a warning

When you file the issue, please clarify exactly what problem you are trying to solve, with specific code references. The in_app_purchase example does not import the platform interface.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft July 17, 2025 17:23
@arrrrny arrrrny changed the title show InAppPurchasePlatform, InAppPurchasePlatformAddition [in_app_purchase] show InAppPurchasePlatform, InAppPurchasePlatformAddition Jul 17, 2025
@arrrrny
Copy link
Author

arrrrny commented Jul 17, 2025

@stuartmorgan-g Is it really wise to have contributors to update the versions? I think that could cause conflicts between PRs?

@stuartmorgan-g
Copy link
Contributor

Is it really wise to have contributors to update the versions?

If I didn't think so, I wouldn't have created a policy requiring it.

I think that could cause conflicts between PRs?

It occasionally causes conflicts that are trivial to resolve when we are ready to commit the PR, yes. That's covered in one of the FAQ linked in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
p: in_app_purchase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arrrrny @stuartmorgan-g