-
Notifications
You must be signed in to change notification settings - Fork 6k
fix Memory leak when using PlatformView [IOS] #24714 #7919
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will land on green |
Good catch. Thanks. I wonder if we should provide a custom GL proc resolver with instrumented variants of the OpenGL methods where we can do sanity checks like this. There may be more instances of such leaks. CC @jason-simmons |
flutter/engine@33bb91c...f80928a git log 33bb91c..f80928a --no-merges --oneline f80928a Roll src/third_party/skia fdd15284affe..ee1c8a733e5b (15 commits) (flutter/engine#7924) 93f339f fix Memory leak when using PlatformView [IOS] #24714 (flutter/engine#7919) 2d33e77 Roll src/third_party/skia 969659dbb313..fdd15284affe (2 commits) (flutter/engine#7922) 6d4edf2 Roll src/third_party/skia 9431161ca973..969659dbb313 (3 commits) (flutter/engine#7921) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
@chinmaygarde it is a big problem to me ,can you give me some help |
This is my investigation, thanks!
https://juejin.im/post/5c6e6dd5f265da2dcf62821f
Fixes flutter/flutter#24714