This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix attribute replace bug in TextAXNodeWrapper #24986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing an int/float/bool attribute on the test node, we want to erase the range from the iterator returned by remove_if to end(), which may be an empty range. In the case where remove_if() returns end(), the single-parameter variant of erase() attempts to remove an element past the end of the container.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
When replacing an int/float/bool attribute on the test node, we want to erase the range from the iterator returned by remove_if to end(), which may be an empty range. In the case where remove_if() returns end(), the single-parameter variant of erase() attempts to remove an element past the end of the container.
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
When replacing an int/float/bool attribute on the test node, we want to erase the range from the iterator returned by remove_if to end(), which may be an empty range. In the case where remove_if() returns end(), the single-parameter variant of erase() attempts to remove an element past the end of the container.
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
When replacing an int/float/bool attribute on the test node, we want to erase the range from the iterator returned by remove_if to end(), which may be an empty range. In the case where remove_if() returns end(), the single-parameter variant of erase() attempts to remove an element past the end of the container.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Replace.*Attribute methods of TextAXNodeWrapper
test helper class.
When replacing an int/float/bool attribute on the test node, we want to
erase the range from the iterator returned by remove_if to end(), which
may be an empty range. In the case where remove_if() returns end(), the
single-parameter variant of erase() attempts to remove an element past
the end of the container.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.