Improve error message when CanvasKit is unable to parse a font #24827
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| return _RegisteredFont(bytes, family, typeface); | ||
| } else { | ||
| html.window.console.warn('Failed to load font $family at $url'); | ||
| html.window.console.warn('Verify that $url contains a valid font.'); |
There was a problem hiding this comment.
Let's add an indirection, e.g. a mutable top-level void Function() printWarning; that could be mocked in a test so we can test that we log these warnings.
Fixes flutter/flutter#76804
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.