This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Address platform changes in the integration tests. Part 1 #20008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ferhatb
approved these changes
Jul 24, 2020
|
Merging the PR to fix the tree quickly. This change will fix 'felt test firefox' step failing on the bots. Example: https://ci.chromium.org/p/flutter/builders/prod/Linux%20Web%20Engine/1027 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way platform is chosen in Flutter has changed recently.
Now linux is recognized as a separate platform and linux machines does not return "android" as the platform anymore.
Therefore we need to stop running android tests on linux desktop web test runners.
As Part2, I'll add another test for linux platform.