This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Android TextInput] clean up nested batch edits in closeConnection() #26628
Merged
fluttergithubbot
merged 2 commits into
flutter:master
from
LongCatIsLooong:android-cleanup-on-close-connection
Jun 10, 2021
Merged
[Android TextInput] clean up nested batch edits in closeConnection() #26628
fluttergithubbot
merged 2 commits into
flutter:master
from
LongCatIsLooong:android-cleanup-on-close-connection
Jun 10, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jun 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2021
jonahwilliams
pushed a commit
to jonahwilliams/engine
that referenced
this pull request
Jun 22, 2021
christopherfujino
added a commit
that referenced
this pull request
Jun 30, 2021
* 'Update Dart SDK to 065872e' * [Android TextInput] clean up nested batch edits in closeConnection() (#26628) * update gcloud credentials (#26868) Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
platform-android
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#83213.
Maybe fixes flutter/flutter#80938
We restart the IME when the framework changes the composing region. When this happens during a batch edit the old connection doesn't get to call
endBatchEdit
so we need to clean that up. Currently if that happens the framework will never be updated (as the batch edit count is always going to be > 0).Per Android API docs:
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.