This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix and re-enable flaky test MessageLoopTaskQueue::ConcurrentQueueAndTaskCreatingCounts.
#25826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dTaskCreatingCounts`. The intent of this test was to verify that tasks could be posted to tasks queues concurrently. While there were no data races in test (verified with TSAN), I was unable to check if there there were race conditions. This was hard to determine because queue creation and the test assertions could happen as the tasks were being registered. I have simplified the test to make it easier to read while ensuring that task registration does happen concurrently. This has also been verified with TSAN. Fixes flutter/flutter#43858
|
@iskakaushik As discussed. PTAL. I also ensured that more threads posts to fewer queues to ensure contention. |
iskakaushik
approved these changes
Apr 28, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2021
…tQueueAndTaskCreatingCounts`. (flutter/engine#25826)
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
May 5, 2021
…dTaskCreatingCounts`. (flutter#25826)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this test was to verify that tasks could be posted to tasks queues
concurrently. While there were no data races in test (verified with TSAN), I was
unable to check if there there were race conditions. This was hard to determine
because queue creation and the test assertions could happen as the tasks were
being registered. I have simplified the test to make it easier to read while
ensuring that task registration does happen concurrently. This has also been
verified with TSAN.
Fixes flutter/flutter#43858