这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll Angle to pick up UWP support #25007

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Roll Angle to pick up UWP support #25007

merged 2 commits into from
Mar 16, 2021

Conversation

clarkezone
Copy link

Roll Angle to pick up google/angle@06d194e

flutter/flutter#70196
flutter/flutter#14967

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@clarkezone clarkezone self-assigned this Mar 16, 2021
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Mar 16, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@cbracken
Copy link
Member

CLA is good -- one of us is a Googler and @clarkezone has signed the CLA.

@cbracken cbracken added cla: yes and removed cla: no labels Mar 16, 2021
@google-cla
Copy link

google-cla bot commented Mar 16, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 16, 2021
@cbracken cbracken added cla: yes and removed cla: no labels Mar 16, 2021
@cbracken
Copy link
Member

cbracken commented Mar 16, 2021 •
edited
Loading

Re-run of failing task https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Android%20AOT%20Engine/20230/overview

@cbracken cbracken merged commit 4ca02a5 into flutter:master Mar 16, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2021
@engine-flutter-autoroll
4ca02a5 Roll Angle to pick up UWP support (flutter/engine#25007)
44b0626
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@clarkezone @cbracken @hjfreyer
Roll Angle to pick up UWP support (flutter#25007)
0642380 
* Roll Angle

* Update licence goldens for ANGLE

Co-authored-by: Chris Bracken <chris@bracken.jp>
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@clarkezone @cbracken @chriscraws
Roll Angle to pick up UWP support (flutter#25007)
9808146 
* Roll Angle

* Update licence goldens for ANGLE

Co-authored-by: Chris Bracken <chris@bracken.jp>
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@clarkezone @cbracken @duanqz
Roll Angle to pick up UWP support (flutter#25007)
6a4f8a5 
* Roll Angle

* Update licence goldens for ANGLE

Co-authored-by: Chris Bracken <chris@bracken.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

@clarkezone clarkezone

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarkezone @googlebot @cbracken