这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

onDisplayPlatformView JNI #18828

Merged
merged 13 commits into from
Jun 8, 2020
Merged

onDisplayPlatformView JNI #18828

merged 13 commits into from
Jun 8, 2020

Conversation

cg021
Copy link
Contributor

@cg021 cg021 commented Jun 4, 2020

Description

Add JNI method onDisplayPlatformView for hybrid composition in the engine.

Related Issues

flutter/flutter#58288

Tests

I added the following tests:

onDisplayPlatformView__callsPlatformViewsController

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@auto-assign auto-assign bot requested a review from iskakaushik June 4, 2020 18:19
@cg021 cg021 removed the request for review from iskakaushik June 4, 2020 18:20
@cg021 cg021 requested a review from blasten June 5, 2020 01:43
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cg021 cg021 added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 5, 2020
@cg021 cg021 merged commit 773ac97 into flutter:master Jun 8, 2020
@cg021 cg021 deleted the jni_58288 branch June 8, 2020 21:14
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2020
cg021 added a commit to cg021/engine that referenced this pull request Jun 9, 2020
* missing imports

* onDisplayPlatformView JNI

* imports

* ran ./ci/format.sh | patch -p0

* missing imports

* onDisplayPlatformView JNI

* imports

* ran ./ci/format.sh | patch -p0

* missing imports

* ran ./ci/format.sh | patch -p0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants