This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixes Semantic Object memory leak cause of wrong release call #18107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
suggested changes
May 4, 2020
zhongwuzw
commented
May 5, 2020
| SemanticsObject* delegateObject = [[FlutterSemanticsObject alloc] initWithBridge:weak_ptr | ||
| uid:node.id]; | ||
| SemanticsObject* delegateObject = | ||
| [[[FlutterSemanticsObject alloc] initWithBridge:weak_ptr uid:node.id] autorelease]; | ||
| return (SemanticsObject*)[[[FlutterSwitchSemanticsObject alloc] | ||
| initWithSemanticsObject:delegateObject] autorelease]; |
There was a problem hiding this comment.
@gaaclarke Here return directly, release statement would not execute.
There was a problem hiding this comment.
@gaaclarke Hey, can you review this again? 🍻
gaaclarke
approved these changes
May 20, 2020
There was a problem hiding this comment.
Thanks @zhongwuzw looks good, can you spend a minute looking to see if you can make a test for this?
|
I poked around and didn't see an easy way to test beyond looking at retain counts. It's not a huge deal. I just want to find every opportunity to try to build up tests in this code. Thanks @zhongwuzw . |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2020
This was referenced May 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.